Modified vtk.py to import 4.2 version vtk files.#297
Open
matteomoscheni wants to merge 1 commit intoraysect:masterfrom
Open
Modified vtk.py to import 4.2 version vtk files.#297matteomoscheni wants to merge 1 commit intoraysect:masterfrom
matteomoscheni wants to merge 1 commit intoraysect:masterfrom
Conversation
Lack of "sanity check" commands (e.g. assert, error display, exc.) From line 154 suggest modifications which do not work yet.
Member
|
Hey @matteomoscheni, thanks for submitting this contribution. Unfortunately this code isn't ready for merging. Here are a few observations:
@CnlPepper may have some more comments. I think we should probably make these fixes in a new branch. So it would be better if you can read up on git flow before we proceed. |
Author
|
Thank you @mattngc for the advices and I apologize for the indentation errors. It would be great to have a "unified" script able to distinguish between 2.0 and 4.2 version! |
Member
|
Is this still being worked on or can I close it as a stale PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I have mentioned in our latest Skype call, I hereby submit a pull request with the modified vtk.py file.
Please notice that it would be nice if you could merge it with the existing one for the import of the 2.0 version. In this way, one can import either a 2.0 or a 4.2 version without bothering about which function to choose.
Lack of "sanity check" commands (e.g. assert, error display, exc.)
From line 154 you will find some suggested modifications to export_vtk. Given the absence of any reference file, I have no idea how to correctly structure the exported file.